Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E testing #3884

Merged
merged 10 commits into from
Nov 22, 2023
Merged

E2E testing #3884

merged 10 commits into from
Nov 22, 2023

Conversation

J3fftw1
Copy link
Contributor

@J3fftw1 J3fftw1 commented Jun 30, 2023 •
edited by WalshyDev
Loading

Description

We want to start putting more velocity into PRs, this means we also want more validation around the PRs we want to merge in.

Unit tests are good but can't catch everything, they can all pass but the plugin fails to start for XYZ reason. Therefore, we want to start adding some e2e tests for these cases where unit tests cannot provide the validation we want.

Proposed changes

Adds a new workflow to test all supported MC versions (+ Java versions) in a live server environment.
This uses a new "e2e-tester" tool which is currently private within the org but will soon be open.

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@github-actions
Copy link
Contributor

Your Pull Request was automatically labelled as: "🎈 Feature"
Thank you for contributing to this project! ❤️

@github-actions github-actions bot added the 🎈 Feature This Pull Request adds a new feature. label Jun 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023 •
edited
Loading

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: fb37d498

https://preview-builds.walshy.dev/download/Slimefun/3884/fb37d498

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@WalshyDev WalshyDev changed the title -WIP e2e testing [WIP] E2E testing Jun 30, 2023
@WalshyDev
Copy link
Member

WalshyDev commented Jul 1, 2023 •
edited
Loading

TODO list:

  • Version matrix
  • Add an initial test which just ensures plugin loads and /sf versions can be ran

@WalshyDev
Copy link
Member

It's coming together
image

@WalshyDev WalshyDev changed the title [WIP] E2E testing E2E testing Jul 4, 2023
@WalshyDev WalshyDev marked this pull request as ready for review July 4, 2023 23:33
@WalshyDev WalshyDev requested a review from a team as a code owner July 4, 2023 23:33
@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Jul 7, 2023
@WalshyDev WalshyDev removed the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Jul 7, 2023
@J3fftw1 J3fftw1 force-pushed the feature/e2e-testing branch 2 times, most recently from d8de794 to 813985a Compare July 16, 2023 21:14
JustAHuman-xD
JustAHuman-xD approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anything goes wrong blame Jeff KEKW

Sfiguz7
Sfiguz7 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@Sfiguz7 Sfiguz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally not at gunpoint

@Sfiguz7 Sfiguz7 merged commit 1aeb0e8 into Slimefun:master Nov 22, 2023
14 checks passed
@JustAHuman-xD
Copy link
Contributor

Totally not at gunpoint

🤣

@J3fftw1 J3fftw1 deleted the feature/e2e-testing branch November 22, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sfiguz7 Sfiguz7 Sfiguz7 approved these changes

@JustAHuman-xD JustAHuman-xD JustAHuman-xD approved these changes

Assignees

@Sfiguz7 Sfiguz7

@JustAHuman-xD JustAHuman-xD

Labels
🎈 Feature This Pull Request adds a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@J3fftw1 @WalshyDev @JustAHuman-xD @Sfiguz7 @TheBusyBot