Cleanup and add version to preview builds #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Pull Request was automatically labelled as: "🧹 Chores" |
WalshyDev
force-pushed
the
chore/add-ver-to-preview-builds
branch
from
6f246ea
to
ee626e4
Compare
|
bit out of scope but can we add the commit to the preview message as signature so we know if it has changed |
WalshyDev
force-pushed
the
chore/add-ver-to-preview-builds
branch
from
973b4a2
to
366b870
Compare
WalshyDev
changed the title
WalshyDev
force-pushed
the
chore/add-ver-to-preview-builds
branch
from
dfb863b
to
69dbecf
Compare
Sfiguz7
previously approved these changes
Jul 7, 2023
|
@WalshyDev can you fire a preview build so we know how it looks? |
WalshyDev
force-pushed
the
chore/add-ver-to-preview-builds
branch
from
69dbecf
to
f3f6319
Compare
|
Nope, it runs on |
|
ugh |
|
yeah trying to make this actually run as a test is annoying, in theory it'll work now but I'm sure another error will happen |
WalshyDev
force-pushed
the
chore/add-ver-to-preview-builds
branch
from
ddf460b
to
16871dd
Compare
|
yeah i give up, we'll just test once merged |
WalshyDev
force-pushed
the
chore/add-ver-to-preview-builds
branch
from
16871dd
to
cd699ce
Compare
WalshyDev
force-pushed
the
chore/add-ver-to-preview-builds
branch
from
cd699ce
to
c0e0b64
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sefiraat
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the version in preview builds from
4.9-UNOFFICIALtoPreview Build #<pr-num>-<hash>Just a nice way to see what preview build we're running, check it's latest, check it's the right pr, etc.
Also does some cleanup, we no longer do preview stuff in the "Java CI" workflow and try to work around it firing on both push + pr. There's now just a PR workflow