Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in SlimefunUtils #4214

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mcchampions
Copy link

@mcchampions mcchampions commented Jun 28, 2024

Description

Fix #4212

This issue explains why to change.

or move equalsItemMeta check to if (id != null && id.equals(possibleItemId)) { ?

Proposed changes

  • remove equalsItemMeta check
  • rename var

Related Issues (if applicable)

#4212

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@mcchampions mcchampions requested a review from a team as a code owner June 28, 2024 00:39
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Jun 28, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in SlimefunUtils
2 participants