Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] fix: fix JsonParser static methods not exist before 1.18 #4238

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

ybw0014
Copy link
Contributor

@ybw0014 ybw0014 commented Sep 9, 2024

Description

Fix the issues where metrics and github service throws exception.
Backward compatibility for 1.16 & 1.17.

Proposed changes

Use JsonUtils instead of JsonParser static methods directly.

Related Issues (if applicable)

N/A

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@ybw0014 ybw0014 requested a review from a team as a code owner September 9, 2024 00:38
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 1f4bb45

https://preview-builds.walshy.dev/download/Slimefun/4238/1f4bb451

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@WalshyDev WalshyDev changed the title fix: fix JsonParser static methods not exist before 1.18 [ci skip] fix: fix JsonParser static methods not exist before 1.18 Sep 9, 2024
@WalshyDev WalshyDev merged commit 17d01d7 into Slimefun:master Sep 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants