Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new ItemStack => ItemStack.of #4246

Open
wants to merge 10 commits into
base: walshy/mc-1.21
Choose a base branch
from

Conversation

Intybyte
Copy link
Contributor

Description

Use ItemStack.of instead of new ItemStack

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@Intybyte Intybyte requested a review from a team as a code owner September 25, 2024 18:38
Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

Copy link
Contributor

@ybw0014 ybw0014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would break backward compatibility, add version check

@Intybyte
Copy link
Contributor Author

this would break backward compatibility, add version check

i completely forgot about that, on it

@Intybyte
Copy link
Contributor Author

Applied to everything beside test enviroment for now

Copy link
Contributor

@md5sha256 md5sha256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Intybyte
Copy link
Contributor Author

Intybyte commented Sep 26, 2024

Maybe it is better if I move the StackResolver to the compatibility package, didn't know such a package exists already, should i call it VersionedItemStack?

@Intybyte
Copy link
Contributor Author

Running with a local fork of MockBukkit

@WalshyDev WalshyDev requested a review from a team as a code owner October 1, 2024 00:21
@WalshyDev WalshyDev force-pushed the walshy/mc-1.21 branch 7 times, most recently from afaf3aa to c84e876 Compare October 1, 2024 01:17
…ks-of

# Conflicts:
#	pom.xml
#	src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/tools/ExplosiveTool.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants