Faker converter: better exception message when a formatter is not def…

…ined
Smile-SA · Feb 20, 2024 · a43b809 · a43b809
1 parent 4333243
commit a43b809
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/src/Converter/Proxy/Faker.php b/src/Converter/Proxy/Faker.php
@@ -4,9 +4,11 @@
 
 namespace Smile\GdprDump\Converter\Proxy;
 
+use Exception;
 use Smile\GdprDump\Converter\ConverterInterface;
 use Smile\GdprDump\Converter\Parameters\Parameter;
 use Smile\GdprDump\Converter\Parameters\ParameterProcessor;
+use Smile\GdprDump\Converter\Parameters\ValidationException;
 use Smile\GdprDump\Faker\FakerService;
 
 class Faker implements ConverterInterface
@@ -36,11 +38,16 @@ public function setParameters(array $parameters): void
 
         // Create the formatter now to ensure that errors related to undefined formatters
         // are triggered before the start of the dump process
-        $formatter = $input->get('formatter');
-        // @phpstan-ignore-next-line getFormatter function always returns an array with 2 items
-        [$this->provider, $this->method] = $this->fakerService
-            ->getGenerator()
-            ->getFormatter($formatter);
+        try {
+            $formatter = $input->get('formatter');
+            // @phpstan-ignore-next-line getFormatter function always returns an array with 2 items
+            [$this->provider, $this->method] = $this->fakerService
+                ->getGenerator()
+                ->getFormatter($formatter);
+        } catch (Exception $e) {
+            // Wrap the original exception to make it more clear that the error is due to a faker formatter
+            throw new ValidationException(sprintf('Faker formatter error: %s', $e->getMessage()), $e);
+        }
 
         $this->arguments = $input->get('arguments') ?? [];
         foreach ($this->arguments as $name => $value) {

diff --git a/tests/unit/Converter/Proxy/FakerTest.php b/tests/unit/Converter/Proxy/FakerTest.php
@@ -4,7 +4,6 @@
 
 namespace Smile\GdprDump\Tests\Unit\Converter\Proxy;
 
-use InvalidArgumentException;
 use Smile\GdprDump\Converter\Parameters\ValidationException;
 use Smile\GdprDump\Tests\Unit\Converter\TestCase;
 
@@ -52,7 +51,7 @@ public function testFormatterNotSet(): void
      */
     public function testInvalidFormatter(): void
     {
-        $this->expectException(InvalidArgumentException::class);
+        $this->expectException(ValidationException::class);
         $this->createFakerConverter([
             'formatter' => 'doesNotExist',
             'arguments' => [1, 1],