Decouple django and python versions from other dependencies #459
Conversation
| with: | ||
| name: coverage-results | ||
| name: coverage-results-${{ matrix.python-version }} |
There was a problem hiding this comment.
The coverage results are supposed to be a single combined coverage report. I haven't actually checked if the outputs are being gathered correctly across all branches on github, but it is in tox.
| py312-django50-latest{-pyuca,-noi18n} | ||
| py311-django42-latest | ||
| py39-django32-latest |
There was a problem hiding this comment.
These depends have to match the ones in envlist. A comment in envlist would be useful to ensure these are kept up to date when someone next updates them too.
| @@ -50,7 +50,7 @@ commands = | |||
| rst2html.py --report=info --halt=warning README.rst /dev/null | |||
| rst2html.py --report=info --halt=warning CHANGES.rst /dev/null | |||
|
|
|||
| [py311-latest-noi18n] | |||
| [py311-django50-latest-noi18n] | |||
There was a problem hiding this comment.
I think this section can be removed and just use a conditional setenv in the standard section:
noi18n: DJANGO_SETTINGS_MODULE = django_countries.tests.settings_noi18n
| @@ -28,26 +28,29 @@ jobs: | |||
| run: tox | |||
There was a problem hiding this comment.
Can probably speed things up with tox --parallel
|
I came across this pull request because I was looking for a version of django-countries running on Python-3.12. Just a question, why do you still use tox? I migrated all my projects to just use GitHub actions and their matrix, so that I can combine any Python- with any Django version. This imo is much easier to maintain. |
The main change is decoupling django and python versions from other libraries.
That way, when a new version of django comes out, we can add it without having to update the "latest", "previous" and "legacy" dependencies.
Same thought for new python versions. If a new version comes out or we deprecate an old version, we can add it without having to update other things.
At the same time, this PR updates the github actions versions to their latest version to avoid deprecation notices.