Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in max_length calculation for CountryField with multiple=True #470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cnschn
Copy link

@cnschn cnschn commented Sep 5, 2024

Fixes #469.

I'm not sure if there is a better way to test this - the override_settings decorator does not affect the test models, so I just instantiated a CountryField directly. Also deling the countries.countries in a test inside the TestCountryMultiple messes up other tests in the class, so I added a new one with setUp and tearDown to make sure the test would fail without the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COUNTRIES_FIRST modifies max_length for CountryField(multiple=True)
1 participant