Fix for #653 - animated gifs with mode "P" errors #657
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrief @SmileyChris to be clear, this is an somewhat urgent bugfix, for a regression (see #653 ) that was introduced by my animated formats support PR that was merged for version 2.10. THUMBNAIL_PRESERVE_ANIMATIONS is for later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jrief @SmileyChris somehow the FrameAware wrapper did not always preserve the mode.
I was thinking about adding a "THUMBNAIL_PRESERVE_ANIMATIONS = False", so one can easily completly disable animated stuff. Even when not saving the frames, they are currently processed anyway, thus running into potential performance issues.