Frontend: Validate: ValidationTable: Add error messages inline #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illume
force-pushed
the
inline-error-messages
branch
2 times, most recently
from
5867a6e
to
5bea8ed
Compare
illume
commented
Aug 21, 2023
| errorMessage={errorsData} | ||
| uploadedData={filesWithErrorsList} | ||
| headers={[ |
There was a problem hiding this comment.
These were hardcoded in another spot of the codebase before. At some point these should not be hardcoded, but it's out of scope for this PR.
So that the error messages are shown below the row with the error.
illume
force-pushed
the
inline-error-messages
branch
from
5bea8ed
to
440a309
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://agreeable-wave-08a957210-134.centralus.1.azurestaticapps.net |
siddheshraze
approved these changes
Aug 21, 2023
siddheshraze
pushed a commit
that referenced
this pull request
Jan 4, 2024
So that the error messages are shown below the row with the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that the error messages are shown below the row with the error.
Fixes #39
npm run storybook