Merge pull request #180 from Snapchat/lf/move-only-promise

Allow move-only types in Promise<>. (based on contribution from jb-gcx)
Snapchat · Jul 16, 2024 · 5466945 · 5466945
2 parents 4b57d4a + 00878de
commit 5466945
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/support-lib/cpp/Future.hpp b/support-lib/cpp/Future.hpp
@@ -56,7 +56,7 @@ template <typename T>
 struct ValueHolder {
     using type = T;
     std::optional<T> value;
-    T getValueUnsafe() const {return *value;}
+    T getValueUnsafe() {return std::move(*value);}
 };
 template <>
 struct ValueHolder<void> {

diff --git a/test-suite/handwritten-src/cpp/test_helpers.cpp b/test-suite/handwritten-src/cpp/test_helpers.cpp
@@ -19,6 +19,11 @@
 
 namespace testsuite {
 
+// verify we we can put move only types in futures
+std::unique_ptr<int> testFutureMove() {
+    return djinni::Promise<std::unique_ptr<int>>::resolve(nullptr).get();
+}
+
 SetRecord TestHelpers::get_set_record() {
     return SetRecord { {
         "StringA",