Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add uninstall target #242

Merged
merged 1 commit into from
Aug 5, 2021
Merged

add uninstall target #242

merged 1 commit into from
Aug 5, 2021

Conversation

Ckath
Copy link
Contributor

@Ckath Ckath commented Aug 5, 2021

Resolves: not having a working make uninstall

so without this, currently, wxwidgets generates some broken and useless uninstall.cmake, this generates the proper uninstall target. as someone was complaining about in #78

  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I have confirmed that my code does not introduce intentional security flaws

@Ckath
Copy link
Contributor Author

Ckath commented Aug 5, 2021

errors on downloading a sccache zip on windows builds? @meguminloli
image

@sneedcat
Copy link
Contributor

sneedcat commented Aug 5, 2021

These links expire every 90 days.
Replace the new one from workflow with this new link.

@Ckath
Copy link
Contributor Author

Ckath commented Aug 5, 2021

what about instead doing https://github.com/mozilla/sccache/archive/refs/tags/v0.2.15.zip or is that not new enough,
edit: ah they dont zip them there for the windows msvc release, whatever. I'll just bump with the new nightly link

@Ckath Ckath merged commit 4657568 into Sneeds-Feed-and-Seed:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants