Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to define PerRPCCredentials #520

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Added option to define PerRPCCredentials #520

merged 2 commits into from
Jan 15, 2025

Conversation

sfc-gh-psmolenski
Copy link
Collaborator

@sfc-gh-psmolenski sfc-gh-psmolenski commented Jan 10, 2025 •
edited
Loading

Sanssh client can now be configured to use per-RPC credentials. Useful for using OAuth and ID tokens.

sfc-gh-mwalas
sfc-gh-mwalas approved these changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-mwalas sfc-gh-mwalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I do prefer to review such changes in context of how they are being used, consider next time merging such additions with usage.

@sfc-gh-psmolenski sfc-gh-psmolenski merged commit dcc66d8 into main Jan 15, 2025
7 checks passed
@sfc-gh-psmolenski sfc-gh-psmolenski deleted the per-rpc-credentials branch January 15, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-ikryvanos sfc-gh-ikryvanos sfc-gh-ikryvanos approved these changes

@sfc-gh-mwalas sfc-gh-mwalas sfc-gh-mwalas approved these changes

@sfc-gh-iyashchyshyn sfc-gh-iyashchyshyn sfc-gh-iyashchyshyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-psmolenski @sfc-gh-ikryvanos @sfc-gh-mwalas @sfc-gh-iyashchyshyn