-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mock api entreprise + fix delay type #5512
Conversation
🎉 Deployment for commit 295de39 : IngressesDocker images
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incroyable les mocks, c'est coool
Est-ce que ça fonctionne quand même sans le delay ?
Car en soit, si le delay: 0
règle tout, je suis pas sûr que ça vaille le coup de mocker.... car en soit on perd de la logique de validation (même si c'est pas notre code)
Cypress.Commands.overwrite( | ||
"type", | ||
(originalFn, subject, text, options = {}) => { | ||
options.delay = 0; | ||
//@ts-ignore | ||
return originalFn(subject, text, options); | ||
} | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je suis pas trop chaud d'override la logique par défaut
url: "https://code-du-travail-numerique-preprod.dev.fabrique.social.gouv.fr/api/enterprises?q=CARREFOUR%20BANQUE*", | ||
}, | ||
mockCarrefourBanque | ||
).as("getEnterpriseCarrefourBanque"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ça sert à quoi le as
d'ailleurs, je suis pas sûr qu'on en ait besoin
fix #5513