Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the node version 20 (20.9.0 (LTS)) #312

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix: use the node version 20 (20.9.0 (LTS)) #312

merged 2 commits into from
Nov 5, 2024

Conversation

m-maillot
Copy link
Contributor

fix #311

@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] filesystem +1 104 kB sindresorhus
npm/[email protected] None 0 6.52 kB sindresorhus
npm/[email protected] None 0 23.6 kB coreyfarrell
npm/[email protected] None 0 3.94 kB sindresorhus
npm/[email protected] None 0 11 kB substack
npm/[email protected] None 0 9.16 kB throat-bot
npm/[email protected] None 0 9.65 kB rvagg
npm/[email protected] None 0 16.7 kB wildlyinaccurate
npm/[email protected] None 0 2.77 kB daaku
npm/[email protected] None 0 3.5 kB sindresorhus
npm/[email protected] None 0 22.9 kB jonschlinkert
npm/[email protected] None 0 98.6 kB awaterma
npm/[email protected] None 0 268 kB sebmaster
npm/[email protected] None 0 47.5 kB substack
npm/[email protected] None 0 13 kB gar
npm/[email protected] None 0 3.85 kB sindresorhus
npm/[email protected] environment, filesystem, unsafe +1 160 kB jonaskello
npm/[email protected] None 0 31.9 kB typescript-bot
npm/[email protected] None 0 193 kB ajaff
npm/[email protected] None 0 42.1 kB chaijs
npm/[email protected] None 0 111 kB sindresorhus
npm/[email protected] None 0 102 kB medikoo
npm/[email protected] None 0 8.84 kB feross
npm/[email protected] None 0 40.1 MB typescript-bot
npm/[email protected] environment, eval, filesystem 0 1.24 MB alexlamsl
npm/[email protected] None 0 4.34 kB mathias
npm/[email protected] None 0 4.41 kB mathias
npm/[email protected] None 0 24.4 kB mathias
npm/[email protected] None 0 5.41 kB mathias
npm/[email protected] None 0 3.45 kB lukekarrys
npm/[email protected] None 0 2.62 kB lukekarrys
npm/[email protected] None 0 2.88 kB sindresorhus
npm/[email protected] None 0 9.71 kB wooorm
npm/[email protected] None 0 6.28 kB wooorm
npm/[email protected] None 0 3.38 kB crutchcorn
npm/[email protected] None 0 13.7 kB wooorm
npm/[email protected] None 0 8.37 kB wooorm
npm/[email protected] None 0 7.92 kB wooorm
npm/[email protected] None 0 16.8 kB wooorm
npm/[email protected] None 0 10.6 kB wooorm
npm/[email protected] None 0 5.68 kB gr2m
npm/[email protected] None 0 4.71 kB ryanzim
npm/[email protected] None 0 470 kB garycourt
npm/[email protected] None 0 18.3 kB jfromaniello
npm/[email protected] environment, filesystem, unsafe 0 16.2 kB zertosh
npm/[email protected] filesystem, unsafe Transitive: network +1 354 kB oss-bot
npm/[email protected] None 0 16.6 kB kemitchell
npm/[email protected] None 0 7.93 kB gar
npm/[email protected] None 0 16.8 kB timothygu
npm/[email protected] None 0 18 kB domenic
npm/[email protected] None 0 2.35 kB isaacs
npm/[email protected] filesystem 0 5.78 kB daaku
npm/[email protected] None 0 14.2 kB timoxley
npm/[email protected] None 0 12.4 kB sebmaster
npm/[email protected] None 0 12.3 kB domenic
npm/[email protected] None 0 16.2 kB domenic
npm/[email protected] None 0 49.9 kB domenic
npm/[email protected] environment 0 9.97 kB isaacs
npm/[email protected] None 0 4.47 kB iarna
npm/[email protected] filesystem +1 289 kB dabh
npm/[email protected] None 0 11.8 kB jonschlinkert
npm/[email protected] None 0 36.8 kB substack
npm/[email protected] None 0 0 B
npm/[email protected] None 0 10.6 kB sindresorhus
npm/[email protected] None 0 2.96 kB zkat
npm/[email protected] filesystem 0 12.8 kB isaacs
npm/[email protected] network 0 119 kB lpinca
npm/[email protected] None 0 0 B
npm/[email protected] None 0 23 kB domenic
npm/[email protected] None 0 59 kB lddubeau
npm/[email protected] None 0 6.46 kB raynos
npm/[email protected] filesystem 0 23.4 kB oss-bot
npm/[email protected] None 0 14.8 kB isaacs
npm/[email protected] environment 0 448 kB eemeli
npm/[email protected] environment, filesystem 0 124 kB oss-bot
npm/[email protected] environment, filesystem 0 286 kB oss-bot

View full report↗︎

m-maillot
m-maillot commented Nov 5, 2024
View reviewed changes
package.json
@@ -63,9 +63,7 @@
"test:type": "tsc --noEmit",
"test:unit": "jest",
"test:update": "jest --updateSnapshot",
"test:watch": "yarn test:unit --watch",
"build": "tsc && rm -rf ./dist/update-cc/data-cc && cp -r ./update-cc/data-cc ./dist/update-cc/data-cc",
"update-cc": "npm run build && node dist/update-cc/index.js"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ce code n'est plus utilisé. On a migré sur l'admin la gestion des CC (ajout/suppression...)

m-maillot
m-maillot commented Nov 5, 2024
View reviewed changes
src/libs/getAgreementIdFromIdOrIdcc.js
@@ -29,7 +29,7 @@ const isAgreementId = id => typeof id === "string" && /^KALICONT\d{12}$/.test(id
function getAgreementIdFromIdOrIdcc(agreementIdOrIdcc) {
if (isAgreementIdcc(agreementIdOrIdcc)) {
const idcc = Number(agreementIdOrIdcc);
const matchIdcc = ({ num }) => num === idcc;
const matchIdcc = ({ num }) => Number(num) === idcc;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petit fix car avant on avait un number dans le champ num et maintenant c'est un string.

@m-maillot m-maillot merged commit 9f02e51 into master Nov 5, 2024
3 checks passed
@m-maillot m-maillot deleted the fix/node-version branch November 5, 2024 14:28
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
@SocialGroovyBot
chore(release): version 3.193.0
03afcc6 
# [3.193.0](v3.192.0...v3.193.0) (2024-11-05)

### Bug Fixes

* use the node version 20 (20.9.0 (LTS)) ([#312](#312)) ([9f02e51](9f02e51))

### Features

* **data:** 20241105_1444 update ([745cd46](745cd46))
@maxgfr maxgfr removed their request for review November 5, 2024 14:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

🎉 This PR is included in version 3.193.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolineBda carolineBda carolineBda approved these changes

@Viczei Viczei Awaiting requested review from Viczei

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixer Kali-data
2 participants
@m-maillot @carolineBda