Update in accordance with discord changes #1135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nickname is back with the old syntax.
The nickname is back with the old syntax.
atymic
requested changes
Jan 3, 2024
| @@ -115,11 +115,13 @@ protected function formatAvatar(array $user) | |||
| protected function mapUserToObject(array $user) | |||
| { | |||
| return (new User())->setRaw($user)->map([ | |||
| 'id' => $user['id'], | |||
| 'nickname' => $user['username'].($user['discriminator'] !== '0' ? '#'.$user['discriminator'] : ''), | |||
| 'name' => $user['username'], | |||
There was a problem hiding this comment.
Removing the name field here would be a breaking change.
There was a problem hiding this comment.
Happy to dd the username field in addition, but they can always use getRaw to get the other fields.
|
ping @WissemBad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DisplayName, introduced this year by Discord, can now be found alongside the Username and Discriminator.
New returned fields :
id: The user's id (snowflake).nickname: The user's name with discriminator (name#0000).username: The user's username (name).discriminator: The user's Discord-tag (0000).global_name: The user's display name, if it is set (Amazing Name).email: The user's email ([email protected]).avatar: The user's avatar URL.