fix: Prevent null array offset errors in Provider.php for ORCID #1143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event user data in the response from ORCID does not have a supplied name, an "array offset" error will be encountered because the
value
key won't exist as it's currently specified."Family names" (or last names) are considered optional by ORCID, which means
$user['person']['name']['family-name']
won't always have a['value']
key available.For the moment, "given names" (or first names) are required by ORCID so there's no problem assuming this
['value']
information will exist in the response, but if ORCID ever does the right thing and makes "given names" optional, this will cause errors. It would be a good idea to future proof this with a null coalesce as well. My solution also reduces code duplication.