Skip to content

Commit

Permalink
mm/page_reporting: allow driver to specify reporting order
Browse files Browse the repository at this point in the history
The page reporting order (threshold) is sticky to @pageblock_order by
default.  The page reporting can never be triggered because the freeing
page can't come up with a free area like that huge.  The situation becomes
worse when the system memory becomes heavily fragmented.

For example, the following configurations are used on ARM64 when 64KB base
page size is enabled.  In this specific case, the page reporting won't be
triggered until the freeing page comes up with a 512MB free area.  That's
hard to be met, especially when the system memory becomes heavily
fragmented.

   PAGE_SIZE:          64KB
   HPAGE_SIZE:         512MB
   pageblock_order:    13       (512MB)
   MAX_ORDER:          14

This allows the drivers to specify the page reporting order when the page
reporting device is registered.  It falls back to @pageblock_order if it's
not specified by the driver.  The existing users (hv_balloon and
virtio_balloon) don't specify it and @pageblock_order is still taken as
their page reporting order.  So this shouldn't introduce any functional
changes.

Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Gavin Shan <[email protected]>
Reviewed-by: Alexander Duyck <[email protected]>
Cc: Anshuman Khandual <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: David Hildenbrand <[email protected]>
Cc: "Michael S. Tsirkin" <[email protected]>
Cc: Will Deacon <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Gavin Shan authored and torvalds committed Jun 29, 2021
1 parent f58780a commit 9f849c6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
3 changes: 3 additions & 0 deletions include/linux/page_reporting.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ struct page_reporting_dev_info {

/* Current state of page reporting */
atomic_t state;

/* Minimal order of page reporting */
unsigned int order;
};

/* Tear-down and bring-up for page reporting devices */
Expand Down
6 changes: 6 additions & 0 deletions mm/page_reporting.c
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,12 @@ int page_reporting_register(struct page_reporting_dev_info *prdev)
goto err_out;
}

/*
* Update the page reporting order if it's specified by driver.
* Otherwise, it falls back to @pageblock_order.
*/
page_reporting_order = prdev->order ? : pageblock_order;

/* initialize state and work structures */
atomic_set(&prdev->state, PAGE_REPORTING_IDLE);
INIT_DELAYED_WORK(&prdev->work, &page_reporting_process);
Expand Down

0 comments on commit 9f849c6

Please sign in to comment.