Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metrics (prometheus + micrometer) #110

Merged
merged 4 commits into from
Oct 13, 2024
Merged

feat: metrics (prometheus + micrometer) #110

merged 4 commits into from
Oct 13, 2024

Conversation

yaansz
Copy link
Member

@yaansz yaansz commented Oct 8, 2024

No description provided.

@yaansz yaansz self-assigned this Oct 8, 2024
Copy link
Member

@FerroEduardo FerroEduardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remover @Bean do MainExceptionController, transformar o mesmo em um @Component e mudar o construtor para o seguinte:

public MainExceptionController(
        @Value("${log.channel.id:#{null}}") String channelId,
        @Value("${log_directory:#{null}}") String logDirectory
) {
    this.channelId = channelId;
    this.logDirectory = logDirectory == null ? null : Path.of(logDirectory);
}

Estava retornando um erro quando os valores não eram informados e o @Bean retornava null.

build.gradle Outdated
Comment on lines 40 to 42
implementation("com.github.Softawii:curupira:v1.0.0") {
changing = true
}
Copy link
Member

@FerroEduardo FerroEduardo Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
implementation("com.github.Softawii:curupira:v1.0.0") {
changing = true
}
implementation("com.github.Softawii:curupira:v1.0.0") {
exclude module: 'slf4j-simple'
changing = true
}
implementation 'org.apache.logging.log4j:log4j-slf4j2-impl:2.24.1'

Adicionar essas instruções para melhorar a integração com o SLF4J do Curupira

@FerroEduardo
Copy link
Member

Atualizar gradle:

./gradlew wrapper --gradle-version latest

@yaansz yaansz merged commit 69ec51a into main Oct 13, 2024
1 check passed
@yaansz yaansz deleted the feature/metrics branch October 13, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants