Implement subscribe_id and id i32 to EntryUpdate #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmittag
commented
Sep 10, 2024
| Some(_metadata) => { | ||
| valid_requests.insert(id, vec![broker::Field::Datapoint].into_iter().collect()); | ||
| } | ||
| None => return Err(tonic::Status::new(tonic::Code::NotFound, "Path not found")), |
There was a problem hiding this comment.
Suggested change
| None => return Err(tonic::Status::new(tonic::Code::NotFound, "Path not found")), | |
| None => return Err(tonic::Status::new(tonic::Code::NotFound, "ID not found")), |
| @@ -165,6 +196,8 @@ pub struct NotificationError {} | |||
|
|
|||
| #[derive(Debug, Clone, Default)] | |||
| pub struct EntryUpdate { | |||
| pub id: Option<i32>, | |||
There was a problem hiding this comment.
In my opinion EntryUpdate should have one of ìd or path other one could be get by some functions. Does not make sense to save both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we decided to use a separate request for ID and path for subscribe call this is the implementation for it.