DATAGO-84852: C-EMA restart resilience for scan jobs #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodiRealist
requested review from
rudraneel-chakraborty,
CameronRushton and
moodiRealist
and removed request for
rudraneel-chakraborty and
CameronRushton
...java/com/solace/maas/ep/event/management/agent/config/eventPortal/EventPortalProperties.java
Outdated
Show resolved
Hide resolved
...application/src/main/java/com/solace/maas/ep/event/management/agent/service/ScanService.java
Show resolved
Hide resolved
...cation/src/test/java/com/solace/maas/ep/event/management/agent/service/ScanServiceTests.java
Outdated
Show resolved
Hide resolved
...cation/src/test/java/com/solace/maas/ep/event/management/agent/service/ScanServiceTests.java
Outdated
Show resolved
Hide resolved
...cation/src/test/java/com/solace/maas/ep/event/management/agent/service/ScanServiceTests.java
Outdated
Show resolved
Hide resolved
...java/com/solace/maas/ep/event/management/agent/subscriber/PersistentMessageHandlerTests.java
Outdated
Show resolved
Hide resolved
rudraneel-chakraborty
requested changes
Oct 19, 2024
...java/com/solace/maas/ep/event/management/agent/subscriber/PersistentMessageHandlerTests.java
Outdated
Show resolved
Hide resolved
...m/solace/maas/ep/event/management/agent/subscriber/ScanJobPersistentMessageHandlerTests.java
Outdated
Show resolved
Hide resolved
...ava/com/solace/maas/ep/event/management/agent/subscriber/SolacePersistentMessageHandler.java
Outdated
Show resolved
Hide resolved
rudraneel-chakraborty
approved these changes
Oct 23, 2024
|
SonarQube Quality Gate
|
rudraneel-chakraborty
approved these changes
Oct 24, 2024
mynecker
deleted the
mynecker/DATAGO-84852-cema-restart-resilient-scan-job
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Scan jobs executed by managed EMAs must be resilient to EMA restarts during execution of a scan jobs. Ack'ing of scan job command messages must only happen, after the entire scan job is finished.
To decide, when a scan job is finished a polling mechanism was added to query periodically the
ScanManagerabout the status of a specific scan job.A dedicated thread pool was added to
SolacePersistentMessageHandlerto be able to wait for scan jobs to finish and not block further scan jobs.How was this change implemented?
Java
How was this change tested?
IT tests and end-to-end tests in development environment
Is there anything the reviewers should focus on/be aware of?