DATAGO-93783: Fix cfg push cycle time bug by putting back the setting of the createdTime #231
+45
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g of the createdTime
moodiRealist
temporarily deployed
to
build_pr
GitHub Actions
Inactive
| @@ -91,6 +92,7 @@ public void execute(CommandMessage request) { | |||
| Validate.notEmpty(request.getCommandBundles(), "CommandBundles must not be empty"); | |||
| Validate.notEmpty(request.getCommandBundles().get(0).getCommands(), "At least one command must be present"); | |||
| CommandRequest requestBO = commandMapper.map(request); | |||
| requestBO.setCreatedTime(Instant.now()); | |||
There was a problem hiding this comment.
Should we not fix this on the mapper?
There was a problem hiding this comment.
Addressed as we discussed. Metrics look good:
based on the new implementation, I couldn't have a status tag. @CameronRushton would that be a deal breaker considering that this PR is only registering success scenarios? I might be able to hard code it and register failure scenarios too. Thoughts?
Never mind, I will refactor and implement it so that it tags the status and registers failures as well.
moodiRealist
had a problem deploying
to
build_pr
GitHub Actions
Failure
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
To fix a bug that prevented reporting configPush cycle time
How was this change implemented?
There was a change in this PR
Which was removed as part of this later PR
How was this change tested?
Manually by validating DD metric values showing up:
Is there anything the reviewers should focus on/be aware of?