Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separated useEffects to only redo API call if dates or statistics are different #71

Merged
merged 4 commits into from
Nov 8, 2023
Merged

separated useEffects to only redo API call if dates or statistics are different #71

merged 4 commits into from
Nov 8, 2023

Conversation

jackschedel
Copy link
Member

No description provided.

@jackschedel jackschedel requested a review from Seth10001 November 7, 2023 17:05
@jackschedel
Copy link
Member Author

partially completes #65, still need to implement:

  • smart caching of previous date queries
  • granularityMs in API call rather than postprocessing

Seth10001
Seth10001 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@Seth10001 Seth10001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it locally, but the code changes seem legit.

If there's frequent changes I should prolly make an ephemeral deployment strategy for PRs

@jackschedel jackschedel merged commit 55f5118 into master Nov 8, 2023
@jackschedel jackschedel deleted the graph-optimize branch November 14, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seth10001 Seth10001 Seth10001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackschedel @Seth10001