Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the debug requirement for BT impls. #39

Merged
merged 3 commits into from
Jan 12, 2025

Conversation

andriyDev
Copy link
Collaborator

The only function that needs BT to be debug is get_graphviz. By isolating the impl blocks, we can allow users to have non-Debug types for their behavior trees, while still allowing it for those who want graphviz stuff!

The only function that needs BT to be debug is `get_graphviz`. By isolating the impl blocks, we can allow users to have non-Debug types for their behavior trees, while still allowing it for those who want graphviz stuff!
Copy link
Owner

@Sollimann Sollimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks! 👍 approved.

Please bump minor version before merging

@andriyDev
Copy link
Collaborator Author

@Sollimann looks like I can't merge after doing a new push :/

@Sollimann Sollimann merged commit a995adc into Sollimann:main Jan 12, 2025
2 checks passed
@andriyDev andriyDev deleted the no-deb branch January 12, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants