Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLLS-221 make binding no-match error more helpful #391

Merged
merged 1 commit into from
Aug 29, 2024
Merged

SLLS-221 make binding no-match error more helpful #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/sonarsource/sonarlint/ls/clientapi/SonarLintVSCodeClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,8 @@ public AssistBindingResponse assistBinding(AssistBindingParams params, SonarLint
@Override
public void noBindingSuggestionFound(String projectKey) {
var messageRequestParams = new ShowMessageRequestParams();
messageRequestParams.setMessage("SonarLint couldn't match SonarQube project '" + projectKey + "' to any of the currently " +
"open workspace folders. Please open your project in VSCode and try again.");
messageRequestParams.setMessage("SonarLint couldn't match the server project '" + projectKey + "' to any of the currently " +
"open workspace folders. Please make sure the project is open in the workspace, or try configuring the binding manually.");
messageRequestParams.setType(MessageType.Error);
var learnMoreAction = new MessageActionItem("Learn more");
messageRequestParams.setActions(List.of(learnMoreAction));
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/sonarsource/sonarlint/ls/clientapi/SonarLintVSCodeClientTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ void testNoBindingSuggestionFound() {

var projectKey = "projectKey";
var messageRequestParams = new ShowMessageRequestParams();
messageRequestParams.setMessage("SonarLint couldn't match SonarQube project '" + projectKey + "' to any of the currently open workspace folders. Please open your project in VSCode and try again.");
messageRequestParams.setMessage("SonarLint couldn't match the server project '" + projectKey + "' to any of the currently open workspace folders. Please make sure the project is open in the workspace, or try configuring the binding manually.");
messageRequestParams.setType(MessageType.Error);
var learnMoreAction = new MessageActionItem("Learn more");
messageRequestParams.setActions(List.of(learnMoreAction));
Expand Down