SLVS-1477 Add more logs to new migration

SonarSource · Oct 1, 2024 · cff3956 · cff3956
1 parent 62ca1e9
commit cff3956
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 0 deletions.
diff --git a/src/ConnectedMode.UnitTests/Migration/BindingToConnectionMigrationTests.cs b/src/ConnectedMode.UnitTests/Migration/BindingToConnectionMigrationTests.cs
@@ -102,6 +102,7 @@ public async Task MigrateBindingToServerConnectionIfNeeded_ConnectionsStorageFil
         serverConnectionsRepository.Received(1).ConnectionsFileExists();
         serverConnectionsRepository.DidNotReceiveWithAnyArgs().TryAdd(default);
         unintrusiveBindingPathProvider.DidNotReceive().GetBindingPaths();
+        logger.Received(1).WriteLine(MigrationStrings.ConnectionMigration_NoMigration);
     }
 
     [TestMethod]
@@ -118,6 +119,7 @@ public async Task MigrateBindingToServerConnectionIfNeeded_ConnectionsStorageDoe
             unintrusiveBindingPathProvider.GetBindingPaths();
             serverConnectionsRepository.TryAdd(Arg.Any<ServerConnection>());
             serverConnectionsRepository.TryAdd(Arg.Any<ServerConnection>());
+            logger.WriteLine(MigrationStrings.ConnectionMigration_EndMigration);
         });
     }
 

diff --git a/src/ConnectedMode/Migration/BindingToConnectionMigration.cs b/src/ConnectedMode/Migration/BindingToConnectionMigration.cs
@@ -88,6 +88,7 @@ private void MigrateBindingToServerConnectionIfNeeded()
     {
         if (serverConnectionsRepository.ConnectionsFileExists())
         {
+            logger.WriteLine(MigrationStrings.ConnectionMigration_NoMigration);
             return;
         }
 
@@ -96,6 +97,7 @@ private void MigrateBindingToServerConnectionIfNeeded()
         {
             MigrateBindingToServerConnection(bindingPath);
         }
+        logger.WriteLine(MigrationStrings.ConnectionMigration_EndMigration);
     }
 
     private void MigrateBindingToServerConnection(string bindingFilePath)

diff --git a/src/ConnectedMode/Migration/MigrationStrings.Designer.cs b/src/ConnectedMode/Migration/MigrationStrings.Designer.cs
diff --git a/src/ConnectedMode/Migration/MigrationStrings.resx b/src/ConnectedMode/Migration/MigrationStrings.resx
@@ -230,4 +230,10 @@
   <data name="ConnectionsJson_DoesNotExist" xml:space="preserve">
     <value>[Migration] Connections.json file does not exist. The new migration has to be performed first.</value>
   </data>
+  <data name="ConnectionMigration_EndMigration" xml:space="preserve">
+    <value>[Connection Migration] End migrating connections from existing bindings</value>
+  </data>
+  <data name="ConnectionMigration_NoMigration" xml:space="preserve">
+    <value>[Connection Migration] Connections.json exists. Migrating connections from existing bindings was not performed</value>
+  </data>
 </root>