Add tests to check if SonarQubeNavigationItem is free-threaded #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
duncanp-sonar
commented
Sep 13, 2023
| @@ -30,29 +32,49 @@ namespace SonarLint.VisualStudio.Integration.UnitTests.TeamExplorer | |||
| [TestClass] | |||
| public class SonarQubeNavigationItemTests | |||
| { | |||
| [TestMethod] | |||
| [Ignore] // Object is created successfully, but an exception when | |||
There was a problem hiding this comment.
I'll create a separate ticket for this and fix it separately.
duncanp-sonar
commented
Sep 13, 2023
| // There's no public documentation on how these whether it's ok to create WPF artefacts like brushes | ||
| // and icons in the constructor. However, this is what the VS Team Explorer implementations of this | ||
| // class are doing, so we assume it's ok. | ||
| // See [VS installation directory]\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer\Microsoft.TeamFoundation.TeamExplorer.Navigation.dll |
There was a problem hiding this comment.
It wasn't obvious whether our code was ok or not, so I found and decompiled the VS implementations to check what they did.
duncanp-sonar
commented
Sep 13, 2023
| [TestMethod] | ||
| public void SonarQubeNavigationItem_Execute() | ||
| { | ||
| // Arrange | ||
| var controller = new ConfigurableTeamExplorerController(); |
There was a problem hiding this comment.
Miscellaneous: minor cleanup. It was trivial to replace the helper class with a mock, and add a CreateTestSubject method.
duncanp-sonar
commented
Sep 13, 2023
| @@ -28,6 +28,7 @@ | |||
| namespace SonarLint.VisualStudio.Integration.TeamExplorer | |||
| { | |||
| [TeamExplorerNavigationItem(SonarQubeNavigationItem.ItemId, SonarQubeNavigationItem.Priority, TargetPageId = SonarQubePage.PageId)] | |||
| [PartCreationPolicy(CreationPolicy.NonShared)] // The VS navigations in MS.TeamFoundation.TeamExplorer.Navigation are non-shared | |||
There was a problem hiding this comment.
The VS components are marked as non-shared.
duncanp-sonar
added a commit
that referenced
this pull request
Sep 26, 2023
ugras-ergun-sonarsource
pushed a commit
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4856