SLVS-1474 Refactor ServerConnectionsProvider #5718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verConnectionRepository instead of ISolutionBindingRepository. The connections are saved in a dedicated repository and is no longer calculated from binding, therefore we need to listen to the repository.
…nsRepository instead of the ISolutionBindingRepository. Now we have a separate file for storing the server connections, so we no longer need to look at the bindings. The ServerConnectionsProvider now works as an adapter: converts the ServerConnection model to the DTO expected by slCore.
The connectionId is of type URI, so we don't need anymore to add the sq| and sc|, which were a workaround needed to determine if, given a connectionId, the server is of type SonarQube or SonarCloud, to be able to calculate the URI needed to get the credentials form the CredentialsStore.
hashicorp-vault-sonar-prod
bot
changed the title
… connection needed for SlCore
Base automatically changed from
gt/refactor-alive-connection-tracker
to
feature/hardening-8-4
October 1, 2024 11:28
|
vnaskos-sonar
pushed a commit
that referenced
this pull request
Oct 1, 2024
vnaskos-sonar
pushed a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1474
Update ServerConnectionsProvider to use the ServerConnectionsRepository instead of the ISolutionBindingRepository.
Now we have a separate file for storing the server connections, so we no longer need to look at the bindings. The ServerConnectionsProvider now works as an adapter: converts the ServerConnection model to the DTO expected by slCore.
Also dropped the no longer needed ConnectionIdHelper:
The connectionId is of type URI, so we don't need anymore to add the sq| and sc|, which were a workaround needed to determine if, given a connectionId, the server is of type SonarQube or SonarCloud (which, in turn, was needed to calculate the URI needed to get the credentials form the CredentialsStore)