Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVS-1385 Manage Connections Dialog: User should be able to edit credentials #5795

Merged
merged 3 commits into from
Nov 5, 2024
Merged

SLVS-1385 Manage Connections Dialog: User should be able to edit credentials #5795

merged 3 commits into from
Nov 5, 2024

Conversation

vnaskos-sonar
Copy link
Contributor

@vnaskos-sonar vnaskos-sonar commented Nov 4, 2024 •
edited by jira bot
Loading

SLVS-1385

Expectations:

  • A connection should be re-triggered when the user edits the credentials
  • If any error occurs, show an error message at the bottom of the dialog

To test:

  1. Bind a solution with a token
  2. Close the solution
  3. Revoke the token
  4. Open the solution again (expect that the binding is broken)
  5. Update with a new token (expect that the solution is bound and you are able to view for example taints)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

gabriela-trutan-sonarsource
gabriela-trutan-sonarsource requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we, please, remove the code duplication from the view model?

@vnaskos-sonar vnaskos-sonar merged commit e1c717d into feature/edit-credentials Nov 5, 2024
12 checks passed
@vnaskos-sonar vnaskos-sonar deleted the vn/refresh-binding-on-update-credentials branch November 5, 2024 14:05
vnaskos-sonar added a commit that referenced this pull request Nov 6, 2024
@vnaskos-sonar
SLVS-1385 Manage Connections Dialog: User should be able to edit cred…
36113b8 
…entials (#5795)
vnaskos-sonar added a commit that referenced this pull request Nov 7, 2024
@vnaskos-sonar
SLVS-1385 Manage Connections Dialog: User should be able to edit cred…
3c099dd 
…entials (#5795)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource gabriela-trutan-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnaskos-sonar @gabriela-trutan-sonarsource