Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config of trackingId #93

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tomitamasa
Copy link

@tomitamasa tomitamasa commented Nov 26, 2023

I have tried specifying a trackingId in YAML.

We have a problem when trying to use the -prune option in our project.
Our project has multiple YAML files for the same environment, and when we execute a command with the -prune option, settings from the last apply YAML file overwrite the others.

Related Issue: #92

A trackingId is explicitly specified in a configuration file.

region: ap-northeast-1
cluster: staging
role: ecsTaskExecutionRole
trackingId: test-tag
rules:
...

The EventBridge console
image

When a trackingId is not specified, the default value is set to the cluster name (ex.staging).
The EventBridge console
image

this closes #92

@tomitamasa tomitamasa changed the title Add config of trackingID Add config of trackingId Nov 27, 2023
@tomitamasa tomitamasa marked this pull request as ready for review November 27, 2023 03:15
@tomitamasa
Copy link
Author

@Songmu
Thanks for the nice tool.

Could you please review this Pull Request?
I apologize for the request I made during ISUCON last week.

@Songmu
Copy link
Owner

Songmu commented Dec 4, 2023

Thanks for the pull request!
I see. I understood that it is a need to attach a specific identifier to a job, especially for deletion.
Sorry for the delay in responding, let me give it some thought, including whether naming it trackingID is appropriate.

@tomitamasa
Copy link
Author

Thank you for your response!

Applying multiple configuration files at different timings might be less common, but it would be appreciated if you could consider this possibility.

@sinsoku
Copy link
Contributor

sinsoku commented Sep 29, 2024

What is the status of this pull request?
We are hoping this pull request will be merged as we have the same issue.

I think trackingId is a good and simple name since the AWS tag key is ecschedule:tracking-id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support an option for arbitrary trackingId?
3 participants