This repository has been archived by the owner on Aug 6, 2024. It is now read-only.
7회차 과제 PR #6
Open
7회차 과제 PR #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findstar
approved these changes
Aug 26, 2022
| } | ||
|
|
||
| private void validate() { | ||
| if (number - manualNumber < 0) { |
There was a problem hiding this comment.
이것도 별도의 method 로 extract 할 수 있습니다.
그러면 비지니스 의미를 명확하게 할 수 있는 별도의 메소드 이름을 생성할 수 있죠 :)
Comment on lines
44
to
+46
| public void drawNumbers() { | ||
| for (int i = 0; i < number; i++) { | ||
| lotteryTickets.addLotteryTicket(numberStrategy); | ||
| for (int i = 0; i < number - manualNumber; i++) { | ||
| lotteryTickets.addAutoTicket(numberStrategy); |
There was a problem hiding this comment.
자동만 처리한다면 메소드 이름을 바꿔볼 수도 있을것 같아요
| @@ -5,12 +5,20 @@ | |||
| import java.util.stream.Collectors; | |||
|
|
|||
| public class LotteryTicket { | |||
| private static final int NUMBER = 6; | |||
|
|
||
| public void printLottoNumbers(String result) { | ||
| System.out.println(result); | ||
| } | ||
|
|
||
| public void printNumber(int manual, int auto) { |
Comment on lines
+46
to
+64
| @Test | ||
| public void testManualNumber(){ | ||
| LotteryMachine lotteryMachine = new LotteryMachine(); | ||
| lotteryMachine.pay(1000); | ||
| assertThatThrownBy(()-> lotteryMachine.setManualNumber(3)).isInstanceOf(IllegalArgumentException.class); | ||
| } | ||
|
|
||
| @DisplayName("수동로또 티켓이 올바르게 당첨 되는 지 확인") | ||
| @Test | ||
| public void testManualTicket(){ | ||
| LotteryMachine lotteryMachine = new LotteryMachine(); | ||
| lotteryMachine.pay(3000); | ||
| lotteryMachine.setManualNumber(3); | ||
| lotteryMachine.buyManualTicket(Arrays.asList("1, 2, 3, 4, 5, 6", | ||
| "1, 3, 5, 7, 9, 11", "2, 4, 6, 8, 10, 12")); | ||
| WinningStat stat = lotteryMachine.getStat(new WinningNumbers("1, 2, 3, 4, 5, 6", 7)); | ||
| assertThat(stat.get(Prize.FIRST)).isEqualTo(1); | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.