Skip to content

Commit

Permalink
jshint task improvements and code refactoring. closes #165
Browse files Browse the repository at this point in the history
  • Loading branch information
Michael Lancaster committed Dec 17, 2014
1 parent b194405 commit 46ec5c7
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 9 deletions.
15 changes: 11 additions & 4 deletions .jshintrc
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
{
"browser": true,
"globals": { "angular": false },
"jquery": true,
"node": true
"node": true,
"esnext": true,
"bitwise": true,
"camelcase": true,
"curly": true,
"immed": true,
"newcap": true,
"noarg": true,
"undef": true,
"unused": "vars",
"strict": true
}
11 changes: 9 additions & 2 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,11 @@ module.exports = function (grunt) {
watch: {
src: {
files: [
'!app/public/js/vendor/**/*.js',
'app/public/js/**/*.js',
'app/public/stylesheets/sass/**/*.scss'
],
tasks: ['dev', 'jshint']
tasks: ['dev']
}
},

Expand Down Expand Up @@ -75,7 +76,13 @@ module.exports = function (grunt) {

// Dev
grunt.registerTask('dev', [
'compass:dev'
'compass:dev',
'jshint'
]);

// Dev
grunt.registerTask('test', [
'jshint'
]);

grunt.event.on('watch', function(action, filepath, target) {
Expand Down
1 change: 0 additions & 1 deletion app/public/js/about/aboutCtrl.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ app.controller('AboutCtrl', function ($scope, $http, $rootScope, ngDialog) {
}
};

$rootScope.isAboutVisible = false;
$scope.content = '';

$scope.openModal = function() {
Expand Down
5 changes: 3 additions & 2 deletions package.json
100755 → 100644
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@
"license": "GNU",
"devDependencies": {
"grunt": "^0.4.4",
"grunt-node-webkit-builder": "*",
"grunt-contrib-compass": "*",
"grunt-contrib-watch": "*"
"grunt-contrib-jshint": "^0.10.0",
"grunt-contrib-watch": "*",
"grunt-node-webkit-builder": "*"
}
}

0 comments on commit 46ec5c7

Please sign in to comment.