Exploration fixing features #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkolad
reviewed
Aug 6, 2024
| pub enum InvalidTransactionError { | ||
| /// The sender does not have enough funds to cover the transaction fees | ||
| #[error( | ||
| #[cfg_attr(feature = "std", error( |
There was a problem hiding this comment.
Since we feature gated the entire enum do we have to do it for every case again?
There was a problem hiding this comment.
Actually I am rebasing on latest main from reth, maybe it won't be needed!
Thank you for flagging
bkolad
reviewed
Aug 6, 2024
| use std::{cell::RefCell, thread_local}; | ||
| #[cfg(not(feature = "std"))] | ||
| use zstd::bulk::Decompressor; | ||
| #[cfg(feature = "std")] | ||
| use zstd::bulk::{Compressor, Decompressor}; |
There was a problem hiding this comment.
There is a lot of feature gating here. Instead of use on top of the file could we just use the full path.
For example instead of:
[cfg(feature = "std")]
use zstd::bulk::{Compressor, Decompressor};
we could:
zstd::bulk::Compressor in line 26 (the same for other imports)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
cargo hackto validate that crates `` can compile with all feature combinations.This check fails on version
1.0.3, so this PR also contains fixes for it.Main fixes
thiserror-no-stdin favor of originalthiserrorand feature gate it behindstd.zstdis only supported together withstd, as it is very hard to getzstdwork inno_stdc-kzgis only supported together withstd, for similar reason aszstd.reth-rpc-typesbehinddefaultfeature flag, so it is possible to compile it for riscv