Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor sov-db improvements #1220

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Minor sov-db improvements #1220

merged 5 commits into from
Dec 14, 2023

Conversation

preston-evans98
Copy link
Member

Description

This PR makes three minor changes to the sov-db crate:

  • Re-export the rocksdb crate so that consumers can access its public types. This is useful for configuration.
  • Add the size of the serialized value to the item yielded by DB::Iterator.
  • Use get_pinned_cf instead of get_cf inside of the get<T> method to avoid an unnecessary allocation.

Testing

This change is covered by existing tests.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #1220 (946746d) into nightly (db52671) will decrease coverage by 0.1%.
Report is 4 commits behind head on nightly.
The diff coverage is 75.0%.

Additional details and impacted files
Files Coverage Δ
full-node/db/sov-db/src/native_db.rs 98.6% <100.0%> (ø)
full-node/db/sov-schema-db/src/iterator.rs 98.8% <100.0%> (+0.1%) ⬆️
full-node/db/sov-schema-db/src/lib.rs 91.5% <100.0%> (ø)
full-node/db/sov-db/src/ledger_db/mod.rs 90.8% <33.3%> (ø)
full-node/db/sov-db/src/state_db.rs 92.9% <40.0%> (-2.6%) ⬇️

... and 23 files with indirect coverage changes

@preston-evans98 preston-evans98 added this pull request to the merge queue Dec 14, 2023
Merged via the queue into nightly with commit 96939ff Dec 14, 2023
16 checks passed
@preston-evans98 preston-evans98 deleted the preston/db-apis branch December 14, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants