Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bank: implement get_total_supply_of method. #1240

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Bank: implement get_total_supply_of method. #1240

merged 3 commits into from
Dec 20, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Dec 20, 2023

Description

Adds get_total_supply to the bank module

Linked Issues

Testing

Unit test added

@bkolad bkolad marked this pull request as ready for review December 20, 2023 10:37
@bkolad bkolad requested a review from citizen-stig December 20, 2023 10:37
@bkolad bkolad changed the title Bank: implement get_total_supply Bank: implement get_total_supply_of method. Dec 20, 2023
@bkolad bkolad mentioned this pull request Dec 20, 2023
Closed
@bkolad bkolad requested a review from dubbelosix December 20, 2023 10:54
@bkolad bkolad enabled auto-merge December 20, 2023 10:54
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fee11f) 80.1% compared to head (ca8e613) 80.1%.

Additional details and impacted files
Files Coverage Δ
...system/module-implementations/sov-bank/src/call.rs 90.5% <100.0%> (+0.4%) ⬆️
...ystem/module-implementations/sov-bank/src/query.rs 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@bkolad bkolad added this pull request to the merge queue Dec 20, 2023
Merged via the queue into nightly with commit 081ca9c Dec 20, 2023
16 checks passed
@bkolad bkolad deleted the blaze_bank_supply_of branch December 20, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizen-stig citizen-stig citizen-stig approved these changes

@neysofu neysofu neysofu approved these changes

@dubbelosix dubbelosix Awaiting requested review from dubbelosix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to get a token's total supply
3 participants
@bkolad @citizen-stig @neysofu