Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add risc0 acceleration patch for ed25519 #1245

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

dubbelosix
Copy link
Contributor

Description

Add patches for ed25519 acceleration.

[patch.crates-io]
sha2 = { git = "https://github.com/risc0/RustCrypto-hashes", tag = "sha2/v0.10.6-risc0" }
ed25519-dalek = { git = "https://github.com/risc0/curve25519-dalek", tag = "curve25519-4.1.0-risczero.1" }
crypto-bigint = {git = "https://github.com/risc0/RustCrypto-crypto-bigint", tag = "v0.5.2-risc0"}

The difference in the benchmark is -

verify               | 714955

vs

verify               | 3579797

@dubbelosix dubbelosix marked this pull request as ready for review December 20, 2023 23:03
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9825a71) 80.1% compared to head (1d7609f) 80.2%.
Report is 1 commits behind head on nightly.

Additional details and impacted files

see 18 files with indirect coverage changes

@dubbelosix dubbelosix enabled auto-merge December 21, 2023 16:04
@dubbelosix dubbelosix added this pull request to the merge queue Dec 21, 2023
Merged via the queue into nightly with commit 912dfc9 Dec 21, 2023
16 checks passed
@dubbelosix dubbelosix deleted the dub/risc0-ed25519 branch December 21, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants