Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace StateTranistionOutput with StateTranistion in StateTransitionVerifier #1253

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Dec 21, 2023

Description

This PR introduces the following changes:

  1. Substitutes StateTransitionOutput with the StateTransition struct.
  2. Removes rewarded_address from the StateTransition. It hasn't been used, and I had to set its initialization to 0. We'll reintroduce it when we begin implementing rewards.

Testing

Tests updated.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (734394f) 80.2% compared to head (1beee96) 80.3%.

Additional details and impacted files
Files Coverage Δ
full-node/sov-stf-runner/src/lib.rs 100.0% <ø> (ø)
full-node/sov-stf-runner/src/runner.rs 78.7% <100.0%> (+0.1%) ⬆️
...mplementations/sov-attester-incentives/src/call.rs 86.8% <100.0%> (-0.1%) ⬇️
rollup-interface/src/state_machine/optimistic.rs 0.0% <ø> (ø)
rollup-interface/src/state_machine/zk/mod.rs 50.0% <ø> (ø)
adapters/mock-zkvm/src/lib.rs 77.8% <50.0%> (+0.4%) ⬆️
adapters/risc0/src/guest.rs 55.0% <0.0%> (+0.9%) ⬆️
adapters/risc0/src/host.rs 44.4% <0.0%> (+0.9%) ⬆️
full-node/sov-stf-runner/src/verifier.rs 20.5% <0.0%> (+0.5%) ⬆️

@bkolad bkolad marked this pull request as ready for review December 21, 2023 20:12
@bkolad bkolad enabled auto-merge December 21, 2023 20:21
@bkolad bkolad added this pull request to the merge queue Dec 21, 2023
Merged via the queue into nightly with commit 38275b1 Dec 21, 2023
16 checks passed
@bkolad bkolad deleted the blaze/stf_commit branch December 21, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants