Add a middle step where the restarter is started from a bat file

plugin_template/BepInEx/plugins/SpaceWarp/restarter/invoke_restarter.bat

@@ -0,0 +1,4 @@
+@echo off
+echo Starting SpaceWarpRestarter.exe...
+cd /d "%~dp0"
+start "" "SpaceWarpRestarter.exe" %*

src/SpaceWarp.UI/Backend/Processes/ProcessStarter.cs

@@ -5,7 +5,7 @@ namespace SpaceWarp.Backend.Processes;
 
 internal static class ProcessStarter
 {
-    private const uint DetachedProcess = 0x00000008;
+    private const uint CreateNewConsole = 0x00000010;
 
     [StructLayout(LayoutKind.Sequential)]
     private struct ProcessInformation
@@ -53,6 +53,10 @@ private static extern bool CreateProcess(
         out ProcessInformation lpProcessInformation
     );
 
+    [DllImport("kernel32.dll", SetLastError = true)]
+    [return: MarshalAs(UnmanagedType.Bool)]
+    private static extern bool CloseHandle(IntPtr hObject);
+
     public static bool StartDetachedProcess(string applicationName, string commandLine)
     {
         var si = new StartupInfo();
@@ -64,13 +68,22 @@ public static bool StartDetachedProcess(string applicationName, string commandLi
             IntPtr.Zero,
             IntPtr.Zero,
             false,
-            DetachedProcess,
+            CreateNewConsole,
             IntPtr.Zero,
             null,
             ref si,
-            out _
+            out var pi
         );
 
-        return success;
+        if (!success)
+        {
+            return false;
+        }
+
+        // Close the handles to the process and thread
+        CloseHandle(pi.hProcess);
+        CloseHandle(pi.hThread);
+
+        return true;
     }
 }

src/SpaceWarp.UI/UI/ModList/ModListController.cs

@@ -352,29 +352,22 @@ private void SetupButtons()
         _applyChangesButton.style.display = DisplayStyle.None;
         _applyChangesButton.RegisterCallback<ClickEvent>(_ =>
         {
-            int currentPid = Process.GetCurrentProcess().Id;
+            var currentPid = Process.GetCurrentProcess().Id;
 
             // We call on restarter to kill the current process 
             // and it will call the restarter to restarter.
             var restarterPath = Path.Combine(
                 SpaceWarpPlugin.Instance.SWMetadata.Folder.FullName,
                 "restarter",
-                "SpaceWarpRestarter.exe"
+                "invoke_restarter.bat"
             );
 
-            // var restarter = new Process();
-            //
-            // // We give the restarter the current_pid so that it can kill it.
-            // restarter.StartInfo = new ProcessStartInfo(restarterPath)
-            // {
-            //     Arguments = $"{currentPid} \"{string.Join(" ", Environment.GetCommandLineArgs()[1..])}\"",
-            //     UseShellExecute = true
-            // };
-            // restarter.Start();
-            // restarter.Dispose();
+            var cmd = $"cmd.exe /C \"" +
+                      $"\"{restarterPath}\" " +
+                      $"{currentPid} " +
+                      $"\"{string.Join(" ", Environment.GetCommandLineArgs()[1..])}\"" +
+                      $"\"";
 
-
-            var cmd = $"\"{restarterPath}\" {currentPid} \"{string.Join(" ", Environment.GetCommandLineArgs()[1..])}\"";
             Modules.UI.Instance.ModuleLogger.LogDebug($"Starting restarter: {cmd}");
             var result = ProcessStarter.StartDetachedProcess(
                 null,
@@ -384,6 +377,7 @@ private void SetupButtons()
             Modules.UI.Instance.ModuleLogger.LogDebug($"Restarter result: {result}");
 
             // Hang the current process so that the restarter can kill it.
+            // ReSharper disable once LoopVariableIsNeverChangedInsideLoop
             while (result)
             {
                 Thread.Sleep(1000);