Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog styles #209

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Blog styles #209

merged 8 commits into from
Sep 17, 2024

Conversation

Joe-Mwangi
Copy link
Collaborator

@Joe-Mwangi Joe-Mwangi commented Jun 28, 2024

Have you read the contributing guidelines ?

What is the purpose of your pull request?

Proposed changes

  • Replaced predefined CSS classes for blog content styling with Tailwind CSS Typography classes.
  • This change ensures consistent and responsive typography styling across the blog content.
  • I also updated the useEffect hook in the BlogBody component to set the innerHTML of the blog content container directly instead of appending to it, which prevents duplicate content from being rendered when the blogBody prop changes.
  • Styling the First Letter: The first letter of each blog post is now styled to be bold and capitalized
  • Changing Text Color to Darker Shade for better readability and consistency across all blog posts.

Issues I Encountered.

  • HTML Structure Variations from Content Editors: Some blog content uses incorrect HTML tags for formatting. For example: <p> tags are being used for headings instead of semantic tags like <h2> <h3> etc. blog. Which leads to Tailwind’s typography classes (prose) not being fully effective, as they rely on proper HTML semantics.
  • Global Font Family Override: * { font-family: "Poppins", sans-serif; } applies the "Poppins" font family to all elements, including blog content. Even when the prose classes are applied, making the blog body look more bold.

Warning

Please read these points carefully and answer honestly with an X

into all the boxes. Example : [X]

Before submitting a pull request make sure you have:

  • Read the guidelines for contributing.
  • Wrote some tests.
  • Respected the linting guidelines.

Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syt-web-redesign ❌ Failed (Inspect) Sep 17, 2024 4:45pm

src/pages/blog2/sections/BlogBody.jsx Outdated Show resolved Hide resolved
@sonylomo sonylomo requested a review from Ase020 July 9, 2024 08:56
@JimmyTron
Copy link
Member

there's a merge conflict in the offing here.

@sonylomo
Copy link
Collaborator

sonylomo commented Aug 8, 2024

Hey @Joe-Mwangi 👋🏾

Are you still working on this?

@Joe-Mwangi
Copy link
Collaborator Author

Hey @Joe-Mwangi 👋🏾

Are you still working on this?

Yes am working on it. Thanks for the reminder

Copy link
Member

@JimmyTron JimmyTron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@sonylomo sonylomo merged commit 70996b0 into Dev Sep 17, 2024
3 of 4 checks passed
@sonylomo sonylomo deleted the blog-styles branch September 17, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blog content styles not working.
4 participants