-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog styles #209
Merged
Merged
Blog styles #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sonylomo
requested changes
Jul 9, 2024
there's a merge conflict in the offing here. |
Hey @Joe-Mwangi 👋🏾 Are you still working on this? |
Yes am working on it. Thanks for the reminder |
JimmyTron
force-pushed
the
blog-styles
branch
from
September 9, 2024 14:44
8a01779
to
75f78d2
Compare
JimmyTron
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
Ase020
approved these changes
Sep 10, 2024
sonylomo
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the contributing guidelines ?
What is the purpose of your pull request?
Bug fix
New feature
Fixes blog content styles not working. #195
Proposed changes
Issues I Encountered.
<p>
tags are being used for headings instead of semantic tags like<h2> <h3>
etc. blog. Which leads to Tailwind’s typography classes (prose) not being fully effective, as they rely on proper HTML semantics.* { font-family: "Poppins", sans-serif; }
applies the "Poppins" font family to all elements, including blog content. Even when the prose classes are applied, making the blog body look more bold.Warning
Please read these points carefully and answer honestly with an
X
into all the boxes. Example : [X]
Before submitting a pull request make sure you have: