Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix footer spacing issues #223

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Fix footer spacing issues #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ea84d85
fix: adjust ui spacing of footer elements
alvyynm Aug 5, 2024
1cf11f6
fix: item spacing on the copyright message
alvyynm Aug 5, 2024
d79a39e
fix: remove negative margins on the copyright message
alvyynm Aug 5, 2024
6992a0e
fix: reduce logo and icon sizes
alvyynm Aug 5, 2024
33def54
refactor: remove redundant style
alvyynm Aug 5, 2024
fca4c66
test: create tests for link validation in Footer
alvyynm Aug 5, 2024
a8938f6
fix(test): rename Footer component link validation test
alvyynm Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/components/Footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,15 @@ function Footer() {
const year = now.getFullYear();

return (
<footer className="bg-secondary text-white">
<div className="md:p-12 py-8 px-4 relative max-w-[1440px] mx-auto">
<footer className="bg-secondary text-white" data-testid="footer-section">
<div className="md:px-12 md:pt-8 md:pb-[2px] py-8 px-4 max-w-[1440px] mx-auto">
<div className="flex lg:flex-row flex-col md:gap-16 gap-8">
<div className="flex-3 flex flex-col items-center">
{/* logo */}
<LazyLoadImage
src={logo}
alt="logo"
className="w-[124px] h-32 md:ml-0 ml-4 object-contain"
className="h-20 md:ml-0 ml-4 object-contain"
/>
{/* socials */}
<div className="flex gap-4 items-center py-4">
Expand All @@ -104,7 +104,7 @@ function Footer() {
target="_blank"
rel="noopener noreferrer"
aria-label={link.label}
className="w-7 h-7 text-white"
className="w-5 h-5 text-white"
>
{link.icon}
</a>
Expand All @@ -117,7 +117,7 @@ function Footer() {
href={link.href}
target="_blank"
rel="noopener noreferrer"
className="w-7 h-7 text-white"
className="w-5 h-5 text-white"
>
{link.icon}
</a>
Expand All @@ -126,17 +126,17 @@ function Footer() {
</div>

{/* Footer links */}
<div className="grid grid-cols-1 sm:grid-cols-3 gap-12 sm:gap-8">
<div className="grid grid-cols-1 sm:grid-cols-3 md:gap-12 gap-8">
{footerLinks.map((section) => (
<div
key={crypto.randomUUID()}
className="flex flex-col gap-8 text-center lg:text-left"
className="flex flex-col gap-2 md:gap-4 text-center lg:text-left"
>
<h2 className="text-green-footer font-bold sm:text-xl text-lg leading-9">
<h2 className="text-green-footer font-bold sm:text-xl text-lg md:leading-9">
{section.title}
</h2>

<ul className="flex flex-col gap-5 list-none text-sm font-light">
<ul className="flex flex-col gap-3 md:gap-5 list-none text-sm font-light">
{section.links.map((link) =>
link.href ? (
<li key={crypto.randomUUID()}>
Expand All @@ -162,7 +162,7 @@ function Footer() {

{/* Newsletter */}
<div className="flex-2">
<div className="flex flex-col md:gap-8">
<div className="flex flex-col gap-2 md:gap-4">
<h2 className="text-green-footer font-bold sm:text-xl text-lg md:leading-9 mx-auto lg:mx-0 text-center lg:text-left">
Subscribe to our Newsletter
</h2>
Expand Down Expand Up @@ -192,8 +192,8 @@ function Footer() {
</div>
</div>
</div>
<div className="sm:mt-14 mt-10">
<h1 className="text-center text-green-footer my-4 md:my-8">
<div>
<h1 className="text-center text-green-footer my-4 ">
&copy; {year} SpaceYaTech | All Rights Reserved
</h1>
</div>
Expand Down
26 changes: 26 additions & 0 deletions tests/components/footer.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import { expect, test } from "@playwright/test";

test.beforeEach(async ({ page }) => {
await page.goto("http://localhost:5173");
});

test("all links in the Footer component should be valid", async ({ page }) => {
await page.goto("http://localhost:5173");

const component = await page.locator("data-testid=footer-section");

const links = await page.$$eval("data-testid=footer-section a", (anchors) =>
anchors.map((anchor) => anchor.href)
);

// check if the footer section is visible
await expect(component).toBeVisible();

// validate footer links
// eslint-disable-next-line no-restricted-syntax
for (const link of links) {
// eslint-disable-next-line no-await-in-loop
const response = await fetch(link);
expect(response.status).toBe(200);
}
});
Loading