Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (test): write unit tests for Footer #249

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

alvyynm
Copy link
Member

@alvyynm alvyynm commented Sep 24, 2024

Have you read the contributing guidelines ?

What is the purpose of your pull request?

  • Bug fix
  • New feature
  • Documentation

Proposed changes

  1. Solves 🧪 Test: Add Unit and e2e Tests to Footer Component #240 by creating unit tests for Footer component using vitest. I already added E2E tests for the Footer in Fix footer spacing issues #223 using playwright.
  2. Updates playwright.config.cjs to only run e2e tests on test files ending in .spec.js

Warning

Please read these points carefully and answer honestly with an X
into all the boxes. Example : [X]

Before submitting a pull request make sure you have:

  • Read the guidelines for contributing.
  • Wrote some tests.
  • Respected the linting guidelines (read the guide below for help).

How to Check and Fix Linting Issues

Run npm run validate. This command will run prettier and eslint checks to ensure linting guidelines are respected.

  • If the command exits with code 0 (build is successful), there are no linting issues.

  • If the command exits with a code other than 0, scroll up the command output and look for identified linting issues. Fix them and revalidate to check if the issues have been resolved by re-running the command.

@alvyynm alvyynm self-assigned this Sep 24, 2024
@alvyynm alvyynm linked an issue Sep 24, 2024 that may be closed by this pull request
2 tasks
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syt-web-redesign ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 5:03pm

@alvyynm alvyynm added the enhancement New feature or request label Sep 24, 2024
Copy link
Member

@JimmyTron JimmyTron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed finally 🟢🟢🟢 green-light district it is

@sonylomo sonylomo merged commit a211f13 into Dev Oct 15, 2024
4 checks passed
@sonylomo sonylomo deleted the 240-add-unit-and-e2e-tests-to-footer-component branch October 15, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧪 Test: Add Unit and e2e Tests to Footer Component
3 participants