fix: Link to event URL in single event view #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alvyynm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the contributing guidelines ?
What is the purpose of your pull request?
Proposed changes
As pointed out by Juma on WhatsApp, the frontend currently displays a reservation modal when a user clicks the
Reserve for Freebutton in the single event page view.This PR fixes that by taking the user to the event website from the api. I've also renamed the button text from
Reserve for FreetoReserve Ticketssince some events are paid (the api doesn't provide any info on whether the event is free or paid for now).Further considerations
Since there's no differentiator on whether the event is ours or an external one, we can consider adding that marker to the api in the future and allow users to reserve tickets from the event page on our website for internal events.
Warning
Please read these points carefully and answer honestly with an
Xinto all the boxes. Example : [X]
Before submitting a pull request make sure you have:
How to Check and Fix Linting Issues
Run
npm run validate. This command will run prettier and eslint checks to ensure linting guidelines are respected.If the command exits with code 0 (build is successful), there are no linting issues.
If the command exits with a code other than 0, scroll up the command output and look for identified linting issues. Fix them and revalidate to check if the issues have been resolved by re-running the command.