Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: addresses several ui issues in shop #253

Open
wants to merge 10 commits into
base: Dev
Choose a base branch
from

Conversation

alvyynm
Copy link
Member

@alvyynm alvyynm commented Oct 29, 2024

Have you read the contributing guidelines ?

What is the purpose of your pull request?

  • Bug fix
  • New feature
  • Documentation

Proposed changes

This PR fixes the following issues highlited in #230:

  • Duplicate cart icons shown across the shop on mobile
  • Add 8px radius to images in single item view
  • Removes trailing space to item URL in the carousel's Shop Now button
  • Display item categories in appropriate category color codes in the cart drawer
  • Prevent product card from being distorted when the product name is longer than a certain length
  • Display number of items in the cart alongside the cart icon if there's at least one product added

Warning

Please read these points carefully and answer honestly with an X
into all the boxes. Example : [X]

Before submitting a pull request make sure you have:

  • Read the guidelines for contributing.
  • Wrote some tests.
  • Respected the linting guidelines (read the guide below for help).

How to Check and Fix Linting Issues

Run npm run validate. This command will run prettier and eslint checks to ensure linting guidelines are respected.

  • If the command exits with code 0 (build is successful), there are no linting issues.

  • If the command exits with a code other than 0, scroll up the command output and look for identified linting issues. Fix them and revalidate to check if the issues have been resolved by re-running the command.

@alvyynm alvyynm self-assigned this Oct 29, 2024
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syt-web-redesign ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:47pm

@alvyynm
Copy link
Member Author

alvyynm commented Oct 29, 2024

This fixes #230

@alvyynm alvyynm marked this pull request as ready for review October 29, 2024 13:49
@alvyynm alvyynm linked an issue Oct 30, 2024 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI enhancements
1 participant