Adds "Screenshot in Selection" checkbox to screenshot tool #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a checkmark to the screenshot function that allows you to screenshot only the currently selected area
SpaiR
added
enhancement
SpaiR
requested changes
Jul 30, 2023
There was a problem hiding this comment.
Good stuff! For the first time Go user you did it great. 😄
Please address current minor problems and PR will be good to be merged.
Speaking about the feature itself. I found that users hard to find screenshot functionality. If you're interested you can try to implement the next idea: we can add a "Screenshot" action to the context menu. Like, I do select an area, click MRB and I see an option "Screenshot Selection". Something like that.
|
how did i manage to comment on that i swear i commented on the review |
SpaiR
reviewed
Jul 30, 2023
SpaiR
reviewed
Jul 31, 2023
SpaiR
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this is my first time using go so bear with me (this took me 20 hours)
Closes #177
Adds a checkbox that allows you to, if ticked screenshot only the selected area
Output:
Type of change