-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple validator #25
Conversation
…t in existing tests
…dress. Added new method to usps
Pressed the button without writing a description first, please see above for details! |
This is great! I'll look at this soon! Thank you! |
Looks like the tests are failing because the USPS userId isnt being read properly from the environment. I was getting the same message locally which is why I added the dotenv package to dev dependencies which resolved it. Let me know if there is anything I need to change so the tests can run on your end! |
…likely interfering with github secrets
Tried dropping the dotenv package from the environment because I think it was conflicting with GitHub environment variables and causing the tests to fail. Hopefully. |
Got it loaded and the tests passed. My only note would be to run the lint and fix the errors and warnings. You can turn off the I think it's not loading the Github secrets because it's running from a fork. Thanks! I'll merge once the linting is good |
Should be good to go with the linting errors! Thanks for taking a look |
lgtm, thank you ! |
Added the function
verifyMultiple
which allows users to pass up to five addresses to be validated in a single request. Documentation for this feature is here, on page 4:https://www.usps.com/business/web-tools-apis/address-information-api.pdf
Under the section "AddressValidateRequest / Address /", which states: "Up to 5 address verifications can be included per transaction."
I have already written tests for the new functionality which pass, and updated the readme to reflect the new method.
I also had to add
dotenv
to the dev dependencies to run tests locally.