fix: ensure that descent count decrements always happen before comple…

…tion of another descent is sent via channel (#420)
SpecterOps · Feb 15, 2024 · 2a63d3a · 2a63d3a
1 parent 9817ee1
commit 2a63d3a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/go/dawgs/traversal/id.go b/packages/go/dawgs/traversal/id.go
@@ -101,12 +101,12 @@ func (s IDTraversal) BreadthFirst(ctx context.Context, plan IDPlan) error {
 						errors.Add(fmt.Errorf("%w - Limit: %.2f MB - Memory In-Use: %.2f MB", ops.ErrTraversalMemoryLimit, tx.TraversalMemoryLimit().Mebibytes(), pathTree.SizeOf().Mebibytes()))
 					}
 
+					// Mark descent for this segment as complete
+					descentCount.Add(-1)
+
 					if !channels.Submit(traversalCtx, completionC, struct{}{}) {
 						return nil
 					}
-
-					// Mark descent for this segment as complete
-					descentCount.Add(-1)
 				}
 			}); err != nil && err != graph.ErrContextTimedOut {
 				// A worker encountered a fatal error, kill the traversal context