BED-5301/5298: PenTest Result: Internal IP Address Disclosure AND Rate limit Bypass #1163
+122
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ementing our current rate limiting middleware logic
… I need to fix (maybe even add)
ALCooper12
added
the
work in progress
ALCooper12
removed
the
work in progress
superlinkx
reviewed
Feb 25, 2025
…orrected some logic
…pper function for better understanding and readability
ddlees
reviewed
Feb 28, 2025
ddlees
reviewed
Feb 28, 2025
| @@ -166,6 +166,7 @@ type Configuration struct { | |||
| FedRAMPEULAText string `json:"fedramp_eula_text"` // Enterprise only | |||
| EnableTextLogger bool `json:"enable_text_logger"` | |||
| RecreateDefaultAdmin bool `json:"recreate_default_admin"` | |||
| TrustedProxies int `json:"trusted_proxies"` | |||
There was a problem hiding this comment.
I don't think we need this configuration value and can assume only 1 reverse proxy for the majority of cases. Otherwise, we might consider defaulting to 1 instead because coordinating configuration changes for production deployments is painful.
ddlees
requested changes
Feb 28, 2025
ddlees
reviewed
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/api/v2/loginendpoint in order to address part of the requirements for BED-5300Motivation and Context
This PR addresses:
Why is this change required? What problem does it solve?
How Has This Been Tested?
Screenshots (optional):
UI
Terminal
Types of changes
Checklist: