Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bed 5520: searchTab and searchType on tab change #1166

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

benwaples
Copy link
Contributor

@benwaples benwaples commented Feb 24, 2025

Description

Ties current tab to the searchTab value and sets searchType and searchTab on tab change of explore search tab.

Motivation and Context

This PR addresses: BED-5522

Adds deep linking support for the currently selected search tab. And matches current functionality on tab change where we refetch the search of that tab.

How Has This Been Tested?

added unit tests and manually tested

Enable deepLinking browser mocks to test manually

Screenshots (optional):

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

@benwaples benwaples self-assigned this Feb 24, 2025
@benwaples benwaples added enhancement New feature or request user interface A pull request containing changes affecting the UI code. labels Feb 24, 2025
@benwaples benwaples marked this pull request as ready for review February 24, 2025 21:21
@benwaples benwaples closed this Mar 5, 2025
@benwaples benwaples deleted the BED-5444--searchType-on-tab-change branch March 5, 2025 17:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
@benwaples benwaples restored the BED-5444--searchType-on-tab-change branch March 5, 2025 17:15
@benwaples benwaples reopened this Mar 5, 2025
@benwaples benwaples changed the title Bed 5444 search type on tab change Bed 5520: searchTab and searchType on tab change Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request user interface A pull request containing changes affecting the UI code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants