BED-5453: deep linking support for selected environment #1170
+1,161
−669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly remove items found in updatedParams
benwaples
commented
Feb 26, 2025
| @@ -69,6 +69,7 @@ | |||
| "eslint-config-prettier": "^9.1.0", | |||
| "eslint-plugin-react": "^7.34.1", | |||
| "eslint-plugin-react-hooks": "^4.6.0", | |||
| "history": "^5.3.0", | |||
There was a problem hiding this comment.
same package added to bhe and bhce
benwaples
commented
Feb 26, 2025
| }, | ||
| })); | ||
|
|
||
| const QualityAssuranceV2: React.FC = () => { |
There was a problem hiding this comment.
I made a v2 for the QA component to consolidate the state in a similar way as GroupManagementContent because they behave similarly from a selected environment perspective.
Also added a loading state while fetching the environment
benwaples
commented
Feb 27, 2025
| @@ -14,7 +14,7 @@ | |||
| // | |||
There was a problem hiding this comment.
All changes in here are either renaming useAvailableDomains, or porting styles from the original GraphView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Motivation and Context
This PR addresses: BED-5453
Functionality should be the same from BHCEs perspective apart from now seeing the selected environment in the URL.
How Has This Been Tested?
Added Unit tests and performed manual tests.
Screenshots (optional):
Types of changes
Checklist: