BED-5445: Deep linking node search #1182
Open
+241
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwaples
reviewed
Feb 28, 2025
packages/javascript/bh-shared-ui/src/hooks/useExploreGraph/useNodeSearch/useNodeSearch.ts
Outdated
Show resolved
Hide resolved
packages/javascript/bh-shared-ui/src/hooks/useExploreGraph/useNodeSearch/useNodeSearch.ts
Show resolved
Hide resolved
benwaples
reviewed
Mar 6, 2025
Comment on lines
+32
to
+33
| const graphQuery = nodeSearchGraphQuery({ primarySearch, searchType }); | ||
| const { data: graphData } = useQuery(graphQuery); |
There was a problem hiding this comment.
good call keeping this! I realized that if we did use the useExploreGraph directly here then the matchedNode below may not return the node that was searched for in the case where the current searched for node doesnt return in the graph results.
benwaples
approved these changes
Mar 6, 2025
| import { useQuery } from 'react-query'; | ||
| import { SearchValue } from '../../../store'; | ||
| import { useExploreParams } from '../../useExploreParams'; | ||
| import { nodeSearchGraphQuery } from '../queries'; |
There was a problem hiding this comment.
Looks like this introduces a circular dep, I think we just need to specify the import from ../queries/nodeSearch
| dispatch(searchbarActions.sourceNodeEdited(edit)); | ||
| const handleNodeSelected = (selected?: SearchValue): SourceNodeSelectedAction => | ||
| dispatch(searchbarActions.sourceNodeSelected(selected)); | ||
| const { searchTerm, selectedItem, editSourceNode, selectSourceNode } = useNodeSearchSwitch(); |
There was a problem hiding this comment.
Nit: this will trigger api requests without a handlers in ExploreSearch tests, mind adding mocks? no worries if not, the warning would go away when we clean up feature flag logic for this epic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds single node search functionality to our deep linking implementation on the Explore page. This feature can be tested by enabling the
back_button_supportfeature flag. Some other aspects of the Explore page (particularly pathfinding search) may appear temporarily broken when this flag is enabled.Motivation and Context
First search type implemented in the larger deep linking initiative.
This PR addresses: BED-5455
How Has This Been Tested?
Tests have been added to cover the
useNodeSearchhook that wraps the new query param interactions.Screenshots (optional):
Types of changes
Checklist: